w33ble/mediacast
Watch
1
0
Fork
You've already forked mediacast
 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat: always-visible edit affordance; delete moves to edit page #14

Merged
w33ble merged 2 commits from feat/list-edit-and-edit-page-delete into main 2026-09-22 17:21:15 -06:00
Conversation 1 Commits 2 Files changed 6 +162 -63
hijynx commented 2026-09-22 15:21:21 -06:00
Collaborator
Copy link

What

Two related UI changes to the episode row actions:

  1. Done rows show Play + Edit directly (61b1ec8): the "done" badge no longer swaps to "Edit" on hover. The badge is now an always-visible purple Edit anchor (class="badge done edit-link") pointing at the edit page, alongside the existing Play button. The hover text-swap CSS (edit-default/edit-hover spans) is removed.

  2. Delete for done episodes lives on the edit page (de3b352): the edit page gains a "Danger zone" section below the Save/Cancel row with its own confirm-gated form posting to /entries/<id>/delete. Done rows no longer render a list delete form. Failed rows keep their list delete — there is no edit page for failed jobs.

Tests

  • Seam updated: TestPageDeleteFormOnFailedNotDoneRows (done rows must NOT render list delete, failed rows keep it), TestDeleteListFormOnlyOnFailedRows, publicIDFor split into done/failed helpers.
  • New: TestPageDoneRowHasEditLink, TestEditPageRendersDeleteForm, updated TestIndexDoneBadgeIsEditLink (asserts "Edit" label at rest, no hover spans).

mise run check and mise run test green at both commits.

## What Two related UI changes to the episode row actions: 1. **Done rows show Play + Edit directly** (`61b1ec8`): the "done" badge no longer swaps to "Edit" on hover. The badge is now an always-visible purple `Edit` anchor (`class="badge done edit-link"`) pointing at the edit page, alongside the existing Play button. The hover text-swap CSS (`edit-default`/`edit-hover` spans) is removed. 2. **Delete for done episodes lives on the edit page** (`de3b352`): the edit page gains a "Danger zone" section below the Save/Cancel row with its own confirm-gated form posting to `/entries/<id>/delete`. Done rows no longer render a list delete form. Failed rows keep their list delete — there is no edit page for failed jobs. ## Tests - Seam updated: `TestPageDeleteFormOnFailedNotDoneRows` (done rows must NOT render list delete, failed rows keep it), `TestDeleteListFormOnlyOnFailedRows`, `publicIDFor` split into done/failed helpers. - New: `TestPageDoneRowHasEditLink`, `TestEditPageRendersDeleteForm`, updated `TestIndexDoneBadgeIsEditLink` (asserts "Edit" label at rest, no hover spans). `mise run check` and `mise run test` green at both commits.
feat(server): move done-episode delete into the edit page
All checks were successful
ci / check (pull_request) Successful in 3m41s
Details
build / docker (push) Successful in 2m37s
Details
de3b352839
w33ble approved these changes 2026-09-22 15:22:27 -06:00
w33ble merged commit de3b352839 into main 2026-09-22 17:21:15 -06:00
w33ble deleted branch feat/list-edit-and-edit-page-delete 2026-09-22 17:21:15 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
w33ble
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
w33ble/mediacast!14
No description provided.