w33ble/mediacast
Watch
1
0
Fork
You've already forked mediacast
 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat(runner): embed ID3 metadata in extracted mp3 #11

Merged
w33ble merged 1 commit from feat/embed-id3-metadata into main 2026-09-11 10:00:12 -06:00
Conversation 1 Commits 1 Files changed 3 +16 -3
hijynx commented 2026-09-11 09:43:20 -06:00
Collaborator
Copy link

Summary

  • internal/runner/ytdlp.go: add --embed-metadata --no-embed-chapters --no-embed-info-json to the yt-dlp invocation, so the extracted mp3 carries ID3 tags written by ffmpeg after audio conversion.
  • internal/runner/ytdlp_test.go: extend TestYtdlpArgsShape to assert the three new flags.
  • README.md: note in "How it works" that ID3 tags are embedded on the mp3.

Why

Episodes previously carried title/description/source-URL metadata only in SQLite; the mp3 itself was tagless. Embedded tags make the file self-describing for local players and any tool that reads the audio directly. The feed is unchanged.

Tags written: title, description, canonical webpage_url (comment + purl), artist, date, genre. Chapters and the info-json sidecar are explicitly not embedded, keeping the tag set limited to audio metadata. Metadata edits made after extraction still update the feed only (separate concern, out of scope).

## Summary - `internal/runner/ytdlp.go`: add `--embed-metadata --no-embed-chapters --no-embed-info-json` to the yt-dlp invocation, so the extracted mp3 carries ID3 tags written by ffmpeg after audio conversion. - `internal/runner/ytdlp_test.go`: extend `TestYtdlpArgsShape` to assert the three new flags. - `README.md`: note in "How it works" that ID3 tags are embedded on the mp3. ## Why Episodes previously carried title/description/source-URL metadata only in SQLite; the mp3 itself was tagless. Embedded tags make the file self-describing for local players and any tool that reads the audio directly. The feed is unchanged. Tags written: title, description, canonical `webpage_url` (comment + purl), artist, date, genre. Chapters and the info-json sidecar are explicitly not embedded, keeping the tag set limited to audio metadata. Metadata edits made after extraction still update the feed only (separate concern, out of scope).
feat(runner): embed ID3 metadata in extracted mp3
Some checks failed
ci / check (pull_request) Has been cancelled
Details
aca088712c
hijynx force-pushed feat/embed-id3-metadata from aca088712c
Some checks failed
ci / check (pull_request) Has been cancelled
Details
to 850cefc133
All checks were successful
ci / check (pull_request) Successful in 4m13s
Details
2026-09-11 09:45:23 -06:00 Compare
w33ble approved these changes 2026-09-11 09:46:56 -06:00
w33ble merged commit b046586623 into main 2026-09-11 10:00:12 -06:00
w33ble deleted branch feat/embed-id3-metadata 2026-09-11 10:00:13 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
w33ble
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
w33ble/mediacast!11
No description provided.