From 4591a47dbaa62cbd330bbc9b96ace2be1ace8bd6 Mon Sep 17 00:00:00 2001 From: joe fleming Date: Thu, 6 Sep 2018 18:16:34 -0700 Subject: [PATCH] fix: remove listener on form unmount --- packages/search-site/src/index.ejs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/search-site/src/index.ejs b/packages/search-site/src/index.ejs index d6109a7..7fec8bc 100644 --- a/packages/search-site/src/index.ejs +++ b/packages/search-site/src/index.ejs @@ -294,7 +294,10 @@ }; }, created() { - emitter.on('error', msg => this.error = msg); + emitter.on('error', this.setError); + }, + beforeDestroy() { + emitter.off('error', this.setError); }, methods: { handleSubmit() { @@ -311,7 +314,10 @@ }, resetForm() { this.$el.reset(); - } + }, + setError(msg) { + this.error = msg + }, }, });