feat: check for pending status after comment

keep re-trying until state changes to pending, up to 3 times. if state does not change, remove from history so another run will retry

CHANGELOG.md

@@ -1,5 +1,8 @@
 ### Changelog
 
+#### [v1.3.2](https://git.w33ble.com/w33ble/gh-action-bot/compare/v1.3.1...v1.3.2) (25 October 2018)
+- fix: correct month in log output [`07288be`](https://git.w33ble.com/w33ble/gh-action-bot/commit/07288bee33d6861aa53e88e856174868f37b1fd5)
+
 #### [v1.3.1](https://git.w33ble.com/w33ble/gh-action-bot/compare/v1.2.1...v1.3.1) (23 October 2018)
 - feat: add a clean command [`f3773f7`](https://git.w33ble.com/w33ble/gh-action-bot/commit/f3773f7ee7c0de42997a5b19cc5ee215da3f06ec)
 - feat: track processed, comments [`31b55fc`](https://git.w33ble.com/w33ble/gh-action-bot/commit/31b55fc7c2d7042e428a12f04124e1c4cd63fd28)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "gh-action-bot",
-  "version": "1.3.1",
+  "version": "1.3.2",
   "private": true,
   "description": "Action bot for Github",
   "main": "index",

src/clean.mjs

@@ -21,9 +21,7 @@ async function forceRetest() {
   comments
     .filter(comment => bodyRegexp.test(comment.body) && comment.owner === COMMENT_ACTOR)
     .forEach(async comment => {
-      const res = await deleteComment(repo, comment.id);
+      await deleteComment(repo, comment.id);
-      if (res) logger.debug(`Comment ${comment.id} deleted`);
-      else logger.error(new Error(`Failed to remove comment ${comment.id}`));
     });
 }
 

src/force.mjs

@@ -1,7 +1,7 @@
 import dotenv from 'dotenv';
 import logger from './lib/logger.mjs';
 import createRepo from './lib/create_repo.mjs';
-import { createComment, deleteComment } from './lib/comments.mjs';
+import createPullComment from './lib/create_pull_comment.mjs';
 
 dotenv.config();
 
@@ -14,10 +14,7 @@ async function forceRetest() {
   }
 
   const repo = createRepo(ownerRepo);
-  const comment = await createComment(repo, prNumber, PULL_RETEST_BODY);
+  await createPullComment(repo, prNumber, PULL_RETEST_BODY, { delete: true });
-  const res = await deleteComment(repo, comment.id);
-  if (res) logger.debug(`Comment ${comment.id} deleted`);
-  else logger.error(new Error(`Failed to remove comment ${comment.id}`));
 }
 
 forceRetest().catch(err => logger.error(err));

src/index.mjs

@@ -5,12 +5,15 @@ import getComments from './lib/get_comments.mjs';
 import getPull from './lib/get_pull.mjs';
 import getCommits from './lib/get_commits.mjs';
 import getCommitStatus from './lib/get_commit_status.mjs';
-import { createComment, deleteComment } from './lib/comments.mjs';
+import createPullComment from './lib/create_pull_comment.mjs';
+import execAndCheck from './lib/exec_and_check.mjs';
 import History from './lib/history.mjs';
 
 // load env vars from .env file
 dotenv.config();
 
+const sleep = async ms => new Promise(resolve => setTimeout(resolve, ms));
+
 async function ghActionBot() {
   // parse repo name from cli and create repo instance
   const repo = createRepo(process.argv.splice(2)[0]);
@@ -22,6 +25,7 @@ async function ghActionBot() {
     PULL_LABEL_FILTER,
     PULL_AUTHOR_FILTER,
     PULL_RETEST_BODY,
+    ACTION_CHECK_DELAY = 3000,
   } = process.env;
 
   // load the history module
@@ -41,19 +45,30 @@ async function ghActionBot() {
       // keep track of comments that have been processed
       history.add(comment);
 
+      logger.debug(`PROCESS COMMENT ON #${comment.number}`);
+
       const pull = await getPull(repo, comment.number);
 
+      // filter out any closed pulls
       if (pull.state !== 'open') {
-        logger.debug(`SKIP #${pull.number}: state is ${pull.state}`);
+        logger.debug(`SKIP PULL #${pull.number}: state is ${pull.state}`);
-        return false; // filter out any closed pulls
+        return false;
       }
+
+      // filter on owner
       if (PULL_AUTHOR_FILTER && pull.owner !== PULL_AUTHOR_FILTER) {
-        logger.debug(`SKIP #${pull.number}: author is ${pull.owner}`);
+        logger.debug(`SKIP PULL #${pull.number}: author is ${pull.owner}`);
-        return false; // filter on owner
+        return false;
       }
+
+      // filter on label
       if (PULL_LABEL_FILTER && !pull.labels.includes(PULL_LABEL_FILTER)) {
-        logger.debug(`SKIP #${pull.number}: labels are ${pull.labels.join(',')}`);
+        logger.debug(
-        return false; // filter on label
+          `SKIP PULL #${
+            pull.number
+          }: labels missing '${PULL_LABEL_FILTER}', found ${pull.labels.join(',')}`
+        );
+        return false;
       }
 
       return { comment, pull };
@@ -64,28 +79,39 @@ async function ghActionBot() {
     pulls.map(async ({ pull, comment }) => {
       const commit = await getCommits(repo, pull.number, true);
       const buildStatus = await getCommitStatus(repo, commit.sha);
+
       // do nothing if the build has not started, or is pending or successful
       if (!buildStatus || buildStatus.state === 'pending' || buildStatus.state === 'success') {
-        logger.debug(`SKIP #${pull.number}: build status is ${buildStatus.state}`);
+        logger.debug(`SKIP PULL #${pull.number}: build status is ${buildStatus.state}`);
         return false;
       }
+
       return { comment, pull, commit, buildStatus };
     })
   )).filter(Boolean);
 
-  if (records.length) {
+  logger.log(`${records.length ? `Found ${records.length}` : `≧(´▽｀)≦ No`} outstanding failures`);
-    logger.log(`Found ${records.length} outstanding failures`);
-  } else {
-    logger.debug(`Found ${records.length} outstanding failures`);
-  }
 
   await Promise.all(
-    records.map(async record => {
+    records.map(record =>
-      logger.log(`Re-testing PR #${record.pull.number}`);
+      execAndCheck(
-      const comment = await createComment(repo, records[0].pull.number, PULL_RETEST_BODY);
+        () => createPullComment(repo, record.pull.number, PULL_RETEST_BODY, { delete: true }),
-      logger.debug(`Created comment id ${comment.id}`);
+        async () => {
-      await deleteComment(repo, comment.id);
+          logger.debug(`CHECK #${record.pull.number}: verify state change`);
-    })
+
+          // wait for the ci to restart
+          await sleep(ACTION_CHECK_DELAY);
+
+          // check that the commit status is now pending
+          const buildStatus = await getCommitStatus(repo, record.commit.sha);
+          return buildStatus.state === 'pending';
+        },
+        () => {
+          history.remove(record.comment);
+          logger.error(`Pull comment failed to trigger action on pull #${record.pull.number}`);
+        }
+      )
+    )
   );
 }
 

src/lib/comments.mjs

@@ -1,7 +1,12 @@
+import logger from './logger.mjs';
+
 export async function createComment(repo, issueId, body) {
   return repo.issues(issueId).comments.create({ body });
 }
 
 export async function deleteComment(repo, commentId) {
-  return repo.issues.comments(commentId).remove();
+  const res = await repo.issues.comments(commentId).remove();
+  if (res) logger.debug(`Comment ${commentId} deleted`);
+  else logger.error(new Error(`Failed to remove comment ${commentId}`));
+  return res;
 }

src/lib/create_pull_comment.mjs

@@ -0,0 +1,14 @@
+import logger from './logger.mjs';
+import { createComment, deleteComment } from './comments.mjs';
+
+export default async function createPullComment(repo, number, body, opts = {}) {
+  logger.log(`Adding comment to PR #${number}`);
+  const comment = await createComment(repo, number, body);
+  logger.debug(`Created comment id ${comment.id}`);
+
+  const options = Object.assign({ delete: false }, opts);
+
+  if (options.delete) await deleteComment(repo, comment.id);
+
+  return comment.id;
+}

src/lib/exec_and_check.mjs

@@ -0,0 +1,21 @@
+export default async function execAndCheck(fn, test, onFailure = () => {}, opts = { tries: 3 }) {
+  let count = 0;
+
+  const tryExec = async () => {
+    // exec function
+    await fn();
+
+    // check test function result (pass/fail)
+    const res = await test();
+    if (res) return;
+
+    // if retry limit is hit, call failure function
+    count += 1;
+    if (count >= opts.tries) return onFailure(); // eslint-disable-line consistent-return
+
+    // retry the function and retest the results
+    return tryExec(); // eslint-disable-line consistent-return
+  };
+
+  return tryExec();
+}

src/lib/get_comments.mjs

@@ -1,5 +1,10 @@
 import logger from './logger.mjs';
 
+function truncate(str, len = 26) {
+  if (str.length <= len) return str;
+  return `${str.slice(0, len)}...`;
+}
+
 export default async function getEvents(repo, { body, actor } = {}) {
   const events = await repo.events.fetch();
 
@@ -32,14 +37,12 @@ export default async function getEvents(repo, { body, actor } = {}) {
             `SKIP EVENT ${isComment ? `#${comment.payload.issue.number}` : comment.id}: ${
               comment.type
             } ${comment.payload.action} by ${comment.actor.login}`,
-            isComment && !bodyMatch && `(${comment.payload.comment.body.slice(0, 30)})`
+            isComment && !bodyMatch && `(${truncate(comment.payload.comment.body)})`
           );
         }
         return false;
       }
 
-      logger.debug(`PROCESS #${comment.payload.issue.number}`);
-
       return {
         id: comment.id,
         number: comment.payload.issue.number,

src/lib/history.mjs

@@ -1,6 +1,9 @@
 import fs from 'fs';
 import path from 'path';
 
+const MAX_ITEMS = 1000; // max entries in history
+const TRUNCATE_AMOUNT = 200; // count of entries to remove when max is hit
+
 export default class History {
   constructor() {
     this.filePath = path.resolve('data', 'history.json');
@@ -12,19 +15,41 @@ export default class History {
     }
   }
 
-  get(id) {
+  persist() {
-    return this.db.find(doc => parseInt(doc.id, 10) === parseInt(id, 10));
+    fs.writeFileSync(this.filePath, JSON.stringify(this.db), { encoding: 'utf8' });
+  }
+
+  get(id, index = false) {
+    if (!index) {
+      return this.db.find(doc => parseInt(doc.id, 10) === parseInt(id, 10));
+    }
+
+    return this.db.findIndex(doc => parseInt(doc.id, 10) === parseInt(id, 10));
   }
 
   add(doc) {
     // prevent duplicate entries
     if (this.get(doc.id)) return;
 
-    // add doc to history, truncate as needed
+    // add doc to history
     this.db.push(doc);
-    if (this.db.length > 1000) this.db.splice(0, 1000);
+
+    // truncate as needed, removing first TRUNCATE_AMOUNT entries from the array
+    if (this.db.length > MAX_ITEMS) this.db.splice(0, TRUNCATE_AMOUNT);
 
     // write the updated content to the file
-    fs.writeFileSync(this.filePath, JSON.stringify(this.db), { encoding: 'utf8' });
+    this.persist();
+  }
+
+  remove(doc) {
+    const idx = this.get(doc.id, true);
+
+    // removing document at matched index
+    if (idx !== -1) {
+      this.db.splice(idx, 1);
+
+      // write the updated content to the file
+      this.persist();
+    }
   }
 }

src/lib/logger.mjs

@@ -11,7 +11,7 @@ const zeroPad = (str, len) => {
 
 const getTimestamp = () => {
   const d = new Date();
-  return `${[d.getFullYear(), zeroPad(d.getMonth(), 2), zeroPad(d.getDate(), 2)].join('/')} ${[
+  return `${[d.getFullYear(), zeroPad(d.getMonth() + 1, 2), zeroPad(d.getDate(), 2)].join('/')} ${[
     zeroPad(d.getHours(), 2),
     zeroPad(d.getMinutes(), 2),
     zeroPad(d.getSeconds(), 2),