From bfe8799b90edfdbf3def0249c5780a42ee947769 Mon Sep 17 00:00:00 2001 From: Joe Fleming Date: Mon, 11 Jul 2016 16:03:59 -0700 Subject: [PATCH] add job creation error use it on creation error, update tests --- src/constants/events.js | 4 ++-- src/job.js | 2 +- test/src/job.js | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/constants/events.js b/src/constants/events.js index 1fcfeb6..059c147 100644 --- a/src/constants/events.js +++ b/src/constants/events.js @@ -1,8 +1,8 @@ export default { EVENT_QUEUE_ERROR: 'error', - EVENT_JOB_CREATED: 'job:created', EVENT_JOB_ERROR: 'job:error', - EVENT_WORKER_ERROR: 'worker:error', + EVENT_JOB_CREATED: 'job:created', + EVENT_JOB_CREATE_ERROR: 'job:creation error', EVENT_WORKER_COMPLETE: 'worker:job complete', EVENT_WORKER_JOB_CLAIM_ERROR: 'worker:claim job error', EVENT_WORKER_JOB_SEARCH_ERROR: 'worker:pending jobs error', diff --git a/src/job.js b/src/job.js index c1a0b62..01120ef 100644 --- a/src/job.js +++ b/src/job.js @@ -62,7 +62,7 @@ export default class Job extends events.EventEmitter { }) .catch((err) => { this.debug('Job creation failed', err); - this.emit(contstants.EVENT_JOB_ERROR, err); + this.emit(contstants.EVENT_JOB_CREATE_ERROR, err); }); } diff --git a/test/src/job.js b/test/src/job.js index 317a794..888ce8f 100644 --- a/test/src/job.js +++ b/test/src/job.js @@ -133,7 +133,7 @@ describe('Job Class', function () { createIndexMock.returns(Promise.reject(new Error(errMsg))); const job = new Job(mockQueue, index, type, payload); - job.once(contstants.EVENT_JOB_ERROR, (err) => { + job.once(contstants.EVENT_JOB_CREATE_ERROR, (err) => { try { expect(err.message).to.equal(errMsg); done(); @@ -150,7 +150,7 @@ describe('Job Class', function () { sinon.stub(client, 'index', () => Promise.reject(new Error(errMsg))); const job = new Job(mockQueue, index, type, payload); - job.once(contstants.EVENT_JOB_ERROR, (err) => { + job.once(contstants.EVENT_JOB_CREATE_ERROR, (err) => { try { expect(err.message).to.equal(errMsg); done();