w33ble/elastiq
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

error emitters should return more than just the error

Browse Source 
update tests, and properly catch error conditions in worker event tests
This commit is contained in:
Joe Fleming
2016-07-08 17:12:53 -07:00
parent a2391a30c5
commit 362469f541
2 changed files with 60 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
test/src/worker.js
View File

@@ -289,7 +289,6 @@ describe('Worker class', function () {
});
});
describe('claiming a job', function () {
let params;
let job;
@@ -391,12 +390,18 @@ describe('Worker class', function () {
sinon.stub(mockQueue.client, 'update').returns(Promise.reject({ statusCode: 401 }));
worker.on(constants.EVENT_WORKER_JOB_CLAIM_ERROR, function (err) {
expect(err).to.have.property('statusCode', 401);
done();
try {
expect(err).to.have.property('error');
expect(err).to.have.property('job');
expect(err).to.have.property('worker');
expect(err.error).to.have.property('statusCode', 401);
done();
} catch (e) {
done(e);
}
});
worker._claimJob(job);
});
});
describe('failing a job', function () {
@@ -462,8 +467,15 @@ describe('Worker class', function () {
sinon.stub(mockQueue.client, 'update').returns(Promise.reject({ statusCode: 401 }));
worker.on(constants.EVENT_WORKER_FAIL_UPDATE_ERROR, function (err) {
expect(err).to.have.property('statusCode', 401);
done();
try {
expect(err).to.have.property('error');
expect(err).to.have.property('job');
expect(err).to.have.property('worker');
expect(err.error).to.have.property('statusCode', 401);
done();
} catch (e) {
done(e);
}
});
worker._failJob(job);
});
@@ -612,7 +624,10 @@ describe('Worker class', function () {
worker.once(constants.EVENT_WORKER_JOB_EXECUTION_ERROR, (err) => {
try {
expect(err).to.have.property('type', 'UnspecifiedWorkerError');
expect(err).to.have.property('error');
expect(err).to.have.property('job');
expect(err).to.have.property('worker');
expect(err.error).to.have.property('type', 'UnspecifiedWorkerError');
done();
} catch (e) {
done(e);
@@ -654,7 +669,10 @@ describe('Worker class', function () {
// check for timeout event
worker.once(constants.EVENT_WORKER_JOB_TIMEOUT_ERROR, (err) => {
try {
expect(err).to.have.property('type', 'WorkerTimeoutError');
expect(err).to.have.property('error');
expect(err).to.have.property('job');
expect(err).to.have.property('worker');
expect(err.error).to.have.property('type', 'WorkerTimeoutError');
performJobPromise.then(() => {
sinon.assert.notCalled(failStub);
done();